search

Mangopay / mangopay2-php-sdk

PHP SDK for MANGOPAY
https://packagist.org/packages/mangopay/php-sdk-v2
MIT License
123 stars 134 forks source link

add UserCategory #556

Closed H4wKs closed 2 years ago

H4wKs commented 2 years ago
Q A
Branch ? Master
Bug Fix ? No
New feature ? Yes
Deprecation ? No
Tickets Fix #555
Licence MIT

This PR add UserCategory parameter to the User class.

H4wKs commented 2 years ago

I'll close this PR as this was implemented in #558

SoloJr commented 2 years ago

@H4wKs it was decided to go with your implementation for the moment :)

H4wKs commented 2 years ago

@H4wKs it was decided to go with your implementation for the moment :)

That was unexpected @SoloJr. When I saw your code change I told myself I really underestimated all the required changes :x

I guess the problem here is backward compatibility for all current implementation ... not sure what would be the best way to go, implement the new one while keeping also the old class logic, or make a new major update where UserLegal|UserNatural are deprecated and force user to update their code ?