search

Mangopay / mangopay2-php-sdk

PHP SDK for MANGOPAY
https://packagist.org/packages/mangopay/php-sdk-v2
MIT License
122 stars 133 forks source link

Added `CardId` property to PayInExecutionDetailsDirect and used “int” as types for identifiers #563

Closed garsaud closed 1 year ago

garsaud commented 2 years ago

To help with autocompletion and code scanning tools like Phpstan

fredericdelordm commented 2 years ago

Hello @garsaud,

Thank you for the PR. We are looking into it.

iulian03 commented 1 year ago

@garsaud please update your PR with the latest version of master in order to merge. Thanks!

garsaud commented 1 year ago

@iulian03 Master branch is still causing CI failures, because 35e3910c22fc328aea86ae2852d1234937dfb7a3 is not merged yet

iulian03 commented 1 year ago

@garsaud we've just merged a PR that should fix all tests. Please update your PR again with the master branch, thanks! Sorry you had to do it twice :)

garsaud commented 1 year ago

@iulian03 Is it all good now? 🙂