search

Mangopay / mangopay2-php-sdk

PHP SDK for MANGOPAY
https://packagist.org/packages/mangopay/php-sdk-v2
MIT License
123 stars 133 forks source link

Fix PHP 8.2 and Other Related Issues #640

Open mralaminahamed opened 6 months ago

mralaminahamed commented 6 months ago

Changes Proposed in this Pull Request:

  1. PHP 8.2 Compatibility: Resolved issues related to compatibility with PHP 8.2, ensuring the plugin functions smoothly on this PHP version without errors or warnings.
  2. *PHP CS Fixer (3.) Compatibility*: Resolve issues related to compatibility with PHP CS Fixer 3. and update configure file as per new guidelines.

Related Issue(s) and PR(s):

How to Test the Changes in this Pull Request:

  1. Ensure you have PHP 8.2 installed on your development environment.
  2. Apply this PR's changes to your local copy of the plugin.
  3. Test a payment to verify that the reported issues are resolved and enhancements work as expected.
  4. Check for any PHP warnings, errors, or unexpected behavior.

Changelog Entry:

Self-Review Checklist:

Additional Notes:

williamdes commented 6 months ago

I think you should extract into another PR the actual changes of the code and keep this one for the tooling

mralaminahamed commented 6 months ago

What's the expected timeframe for merging this PR into the master branch?

mralaminahamed commented 6 months ago

to be fixed:

* phpcs cache file needs to be deleted

* code is not well aligned

* composer setup in Dockerfiles could be simpler as suggested

@williamdes, I've incorporated the feedback and suggestions from your review and comments. Please take your time to review the changes at your convenience.

Please feel free to share any feedback or suggestions if you have any.

mralaminahamed commented 6 months ago

hi @iulian03, would you please review my pr and prepare for release?

mralaminahamed commented 5 months ago

hi @iulian03, would you please review my pr and prepare for release?

Hi @iulian03, @fredericdelordm,

I hope you're doing well. I submitted a pull request about a month ago to address the MangoPay PHP SDK's incompatibility with PHP 8.2 and later versions. As a developer relying on this SDK, it's crucial for me and others to have it working with the latest PHP versions.

I kindly request your review of the pull request and would greatly appreciate your feedback. If you find the changes satisfactory, it would be fantastic if you could prepare a new release incorporating these compatibility enhancements.

I've been eagerly waiting for an update on the review and release for the past month, and I also reached out about 3 weeks ago seeking your(@iulian03) intentions. Any information you can provide on the progress would be much appreciated.

Thank you for your time and consideration. Looking forward to your response.

iulian03 commented 5 months ago

Hi @mralaminahamed ,

Sorry for the late response. We will check your PR, thank you for the contribution!

mralaminahamed commented 5 months ago

@williamdes, I've made the changes based on your feedback. Could you please take another look and let me know if there's anything else that needs to be addressed? Thanks for your time and guidance!

mralaminahamed commented 3 months ago

Hi @iulian03,

I hope you are doing well. I wanted to follow up on the status of this pull request (#640) that addresses the PHP 8.2 compatibility issues and other related problems.

It's been over a month since I submitted the pull request, and I've been actively working on incorporating the valuable feedback provided by @williamdes and making the necessary changes. The latest updates have been reviewed and approved by @williamdes, indicating that the pull request is ready for final review and merging.

I understand that you and the team might have a busy schedule, but I kindly request an update on the timeline for reviewing and merging these changes. As a developer relying on this SDK, it's crucial to have it compatible with the latest PHP versions, and I believe many others in the community would also benefit from these fixes.

Additionally, I wanted to inquire about your plans for the next release of the Mangopay PHP SDK. It would be great if you could share any information on when we can expect a new version that includes these compatibility enhancements.

pkly commented 1 month ago

It'd be great if you could add tests against php 8.3 as well (tho it seems to work fine from my experience, without the MR)

mralaminahamed commented 1 month ago

Thanks for your feedback, and I will try to add test cases for php 8.3.