search

Mangopay / mangopay2-php-sdk

PHP SDK for MANGOPAY
https://packagist.org/packages/mangopay/php-sdk-v2
MIT License
123 stars 133 forks source link

Fatale error on wrong class name #98

Closed julestex closed 8 years ago

julestex commented 8 years ago

Running the test trigger a fatal error. PHP Fatal error: Class 'MangoPay\Libraries\Upload' not found in /home/jules/v3/mangopay2-php-sdk/MangoPay/ClientLogoUpload.php on line 8

It's because the class https://github.com/Mangopay/mangopay2-php-sdk/blob/master/MangoPay/Libraries/Upload.php is named Page and the file is named Upload.

I'm not sure if we should rename the file or the class. It was introduce in the commit https://github.com/Mangopay/mangopay2-php-sdk/commit/fb533d89e1a6e5aa61948a02bb9cbb4e2ddc5068.

hobailey commented 8 years ago

Absolutely, thanks very much for bringing this to our attention :-)

trompette commented 8 years ago

@hobailey, the fix you made for this issue is very much needed.

When do you think it will be part of a tagged release?

Thanks!

hobailey commented 8 years ago

Done: https://github.com/Mangopay/mangopay2-php-sdk/releases/tag/v2.4.1 Sorry for the delay - should have done it sooner :-/

trompette commented 8 years ago

@hobailey, thanks a lot!

I do not find the new version on packagist. Can you help?

hobailey commented 8 years ago

Hmm, it's supposed to pull though automatically, but I've just done it manually :-)

trompette commented 8 years ago

Thanks a lot!