search

Mangopay / mangopay2-ruby-sdk

Ruby Gem for MANGOPAY
https://rubygems.org/gems/mangopay
MIT License
42 stars 38 forks source link

Backward-compatibility #190

Closed peterb closed 3 years ago

peterb commented 3 years ago

MangoPay::Wallet.create is no longer working after an upgrade from 3.0.33 to 3.0.38. I'm looking into the details of this and will follow up with reproduction steps.

Presumably you are using Semver so this upgrade shouldn't have broken backwards-compatibility?

Is anyone else seeing a similar issue?

mangomaxoasis commented 3 years ago

Hi @peterb We're looking into it

peterb commented 3 years ago

Hi @mangomaxoasis, here are some more details:

WebMock::NetConnectNotAllowedError:
  Real HTTP connections are disabled. Unregistered request: POST https://api.sandbox.mangopay.com/v2.01/
...
  You can stub this request with the following snippet:
peterb commented 3 years ago

I had a look at your Changelog. Since I upgraded from 3.0.33 to 3.0.38, I would expect it to remain compatible, as the only breaking change seems to be in 3.0.32?

peterb commented 3 years ago

The bug seems to have been introduced in 3.0.34.

peterb commented 3 years ago

It would appear that there's been a change to the sandbox environment. Why is the URL v2.01, shouldn't it be v3.0.38? @mangomaxoasis

fredericdelordm commented 3 years ago

Hello @peterb,

Do you still have this issue ?

The URL of the latest version of the API is v2.01 not v3.0.38.

peterb commented 3 years ago

Hi @fredericdelordm, I see that v2.01 is the version of the JSON API, and v3.0.38 is the version of the mangopay2-ruby-sdk, thanks for clarifying that!

The more general issue with mangopay2-ruby-sdk is that there doesn't seem to be a consistent versioning, if there were breaking changes, I would expect the version to jump from 3.0.33 to 4.0.0 as per SemVer

I'm not maintaining the application that uses the mangopay2-ruby-sdk anymore so I'll close this issue.