ManhanGroup / calbuilds

Crowdsourcing authoritative info on recent & ongoing developments in California.
https://calbuilds.manhan.co/
0 stars 2 forks source link

remove the application route mixin from ember simple auth #75

Open kaden-weber opened 11 months ago

kaden-weber commented 11 months ago

Doing this originally caused #71

Additional context This Error appeared when the ember-simple-auth (ESA) application route adapter mixin was removed in this commit This was advertised as a side effect free change by the ESA team, but I've isolated it as the sole cause of this issue. The replacement for the mixin is to call the setup method on the session, which is available on ESA 4.2, the latest version that is compatible with our app.

I have tried updating to that version and then using the session setup method on the application route but it has no effect on the deprecation warning to use the setup method, nor does it fix this error.

My only guess is that the unusual routing structure for this application, where the map route handles both authenticated and unauthenticated children routes, is causing some sort of issue with ESA.

kaden-weber commented 11 months ago

current esa version repo esa version 4 with the setup method available v4 guide for adding the setup method

kaden-weber commented 11 months ago

Note that the setup method as used in the guides is shown as using async/await. Its unclear if an early 3.x app is compatible with that (research needed) Its unclear if it works at all when trying to add async/await.

edit: the demo app is using ember 3.17, so that's a big gap where async/await could have been added sometime between 3.0 and 3.17. Will need to look into this.

kaden-weber commented 11 months ago

mixin docs