ManiMatter / decluttarr

Watches radarr, sonarr, lidarr, readarr and whisparr download queues and removes downloads if they become stalled or no longer needed.
GNU General Public License v3.0
153 stars 20 forks source link

Feature request regarding language support #92 #129

Closed volschin closed 1 month ago

volschin commented 1 month ago

In the readme you describe the missing language support for languages other than english #92 .

You could provide environment variables for those messages you rely on in the program logic. If an environment variable is set, you take the string from there, if not you use the internal english one.

ManiMatter commented 1 month ago

Hi

you are right, that would be an option. However if we go to that level of customizability, I fear at some point the config becomes to hard to understand (regardless whether the option is specified or not).

what I wonder though is whether there is an untranslated way to get these messages, ie all in english.

I see these avenues:

Likeliness: first one probably highest, others probably less.

what do you think? if I had a stab at the first proposal, would you be willing to test?

Update: After looking at the sonarr & qbit source code, I feel reverse engineering the entire mapping does not make sense. Have raised a feature request with sonarr: https://github.com/Sonarr/Sonarr/issues/6959 Feel free to back the request ;)

volschin commented 1 month ago

Regarding the translations in qbt. https://github.com/qbittorrent/qBittorrent/tree/master/src/lang

Could be an option the user copies the needed ts itself and you read it if available.

ManiMatter commented 1 month ago

Regarding the translations in qbt. https://github.com/qbittorrent/qBittorrent/tree/master/src/lang

Could be an option the user copies the needed ts itself and you read it if available.

Technically yes. For the average user I think that is too technical - personally I would prefer if it worked without user involvement

ManiMatter commented 1 month ago

Let‘s park this until https://github.com/Sonarr/Sonarr/issues/6960 is done

volschin commented 1 month ago

That’s fine for me. I only want to submit my idea with the environment variables.

ManiMatter commented 1 month ago

Closed in favor of https://github.com/ManiMatter/decluttarr/issues/132