search

ManiVaultStudio / HDF5Loader

Loader Plugin for HDF5 based formats such as 10X, TOME and H5AD
0 stars 0 forks source link

Fix memory leaks from HDF5Loader data members #4

Closed N-Dekker closed 4 years ago

N-Dekker commented 4 years ago

All five data members of HDF5Loader were leaking:

QString _fileName;
QFileDialog *_openFileDialog;
QComboBox *_conversionCombo;
QCheckBox *_normalizeCheck;
QLabel *_normalizeLabel;

This pull request fixes these memory leaks by declaring them as local variables within HDF5Loader::loadData().

It also replaces an old-style string-based signal-slot connect by a modern (Qt 5) functor-based connect, just to ease fixing the memory leaks.