Open N-Dekker opened 5 years ago
Good idea, let's discuss this with all stakeholders
Hi @N-Dekker. I would be in favor of closing this issue if you agree of course! Currently, the loader adheres to the general settings prefix scheme. Currently, settings are saved in: Software/HDPS/Plugins/ImageLoaderPlugin
, along with others like:
Software/HDPS/Plugins/BIN Loader
Software/HDPS/Plugins/CSV Loader
Are you okay with me closing this issue?
Thanks for reminding me of this issue @ThomasKroes My personal preference would still be to follow the convention of having Software/Organization/Application
. Currently I see in the registry of my rather new Windows installation:
Computer\HKEY_CURRENT_USER\Software\LKEB/CGV\HDPS\Plugins
...
Computer\HKEY_CURRENT_USER\Software\TU Delft / LUMC\Cytosplore
...
Computer\HKEY_CURRENT_USER\Software\HDPS\Plugins/BIN Loader
etc. It isn't really consistent. (Mind the difference between forward slash and backslash!) But maybe it isn't such an important issue. So if you want to close this issue, OK, please go ahead!
Thanks for reminding me of this issue @ThomasKroes My personal preference would still be to follow the convention of having
Software/Organization/Application
. Currently I see in the registry of my rather new Windows installation:Computer\HKEY_CURRENT_USER\Software\LKEB/CGV\HDPS\Plugins ... Computer\HKEY_CURRENT_USER\Software\TU Delft / LUMC\Cytosplore ... Computer\HKEY_CURRENT_USER\Software\HDPS\Plugins/BIN Loader
etc. It isn't really consistent. (Mind the difference between forward slash and backslash!) But maybe it isn't such an important issue. So if you want to close this issue, OK, please go ahead!
Thanks for the swift response. I see your point! I am also in favor of following the scheme you suggest: Software/Organization/Application
I was not aware of the other registry keys, not so neat indeed! Thanks for mentioning this, I will make this a discussion point on the 3D-Omics developers agenda. I will not close this issue until I have more clarity. I will keep you in the loop through this GH issue ;).
Thanks again!
With https://github.com/hdps/ImageLoaderPlugin/commit/1e3957d78dce475b5fbeb81101807e4a08262622 (by @ThomasKroes) persistent settings are stored at Windows registry location "HKEY_USERS\S-1-5-21-195992231-2050535824-2983207818-1002\Software\HDPS\ImageViewer" (on my LUMC pc)
Before we officially release the plugin, maybe we should consider a more specific location. Something like this:
HKEY_USERS \ ... \ Software \ <organization> \ <application> \ <plugin> \ ...
In this case,
<organization>
could be something like "LUMC + TU Delft"I already encountered "CGV TU Delft/Leiden University Medical Center" and "LUMC / TU Delft" in my registry, but I would prefer not to have a slash in the key name.
What do you think?