search

ManiVaultStudio / core

A Flexible and Extensible Visual Analytics Framework for High-Dimensional Data
https://www.manivault.studio/
GNU Lesser General Public License v3.0
9 stars 1 forks source link

Make LogDockWidget inherit from hdps::gui::DockableWidget #12

Closed JulianThijssen closed 1 year ago

JulianThijssen commented 5 years ago

This improves consistency in the code base and makes generating and setting its own ID superfluous.

thoellt commented 3 years ago

I have done this in #135 but I find the DockableWidget a bit confusing. Are the docking extensions actually used in this class? In the end this gets stuffed into a CDockWidget, which handles all the docking. Other CDockWidgets, like _analysisPluginsDockWidget or _settingsDockWidget take widgets directly derived from QWidget.

alxvth commented 1 year ago

I think we can close this? @JulianThijssen @thoellt

ThomasKroes commented 1 year ago

Yes, we can. There is a separate plugin now for logging, hdps::gui::DockableWidget is not there anymore.

alxvth commented 1 year ago

Ok, closing this and the corresponding #135