search

ManiacalLabs / ESPSerialWiFiManager

MIT License
6 stars 1 forks source link

Add mqtt server and port to library #13

Open emogg opened 7 years ago

emogg commented 7 years ago

Not an issue, but a request

adammhaile commented 7 years ago

Not sure what you mean... wouldn't MQTT have to be a separate imported library anyways. Not something built into the ESP network stack that I'm aware of. Can you describe what you wanted in terms of integration in more detail?

emogg commented 7 years ago

Sorry for the delay. I would just like to add somewhere to add the ip address and port of an mqtt server to the configuration options.

adammhaile commented 7 years ago

Still not sure I understand... MQTT doesn't have anything to do with the WiFi other than it uses the network. So adding random MQTT stuff to this library seems a bit weird. We could add all sorts of things. But I'm generally trying to keep this simple. Maybe I could add an option to have arbitrary menu options... so you can add extra things.

emogg commented 7 years ago

Arbitrary seems ok to me. Sure mqtt has nothing to do with wifi configuration. I just wanted to have the option to add various other configuration parameters via your serial configuration library. I can't do that, and I can't find any other serial configuration library. Everybody seems happy with ota configuration (instance the homie library), but serial is much simpler.