search

ManiacalLabs / ESPSerialWiFiManager

MIT License
6 stars 1 forks source link

Choose DHCP or Static, manually configure IP/Gateway/Mask #6

Closed haooken closed 8 years ago

haooken commented 8 years ago

Ability to configure DHCP vs Static connections? I.E. prompt for IP, Mask, Gateway on manual config? I think we had talked about this, but I can see people asking for this to be added.

adammhaile commented 8 years ago

Yeah... not sure how best to handle this. I didn't want to add it to the normal configs because most people wouldn't care and it muddles up the amount of options you have to go through. One thought was to connect as normal then go back later and do the other manual stuff. But some networks may fail to connect without that extra config ahead of time. So how about on all configs... Both Scan and Manual, just a single "Advanced Config? y/n" that then drops you into a new menu before connecting if yes?

On Sat, Jul 23, 2016 at 11:46 AM, Dan notifications@github.com wrote:

Ability to configure DHCP vs Static connections? I.E. prompt for IP, Mask, Gateway on manual config? I think we had talked about this, but I can see people asking for this to be added.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ManiacalLabs/ESPSerialWiFiManager/issues/6, or mute the thread https://github.com/notifications/unsubscribe-auth/AA6a6m5la-S0aN5T7DdiKfTpvOESwL5sks5qYjdigaJpZM4JTYf1 .

haooken commented 8 years ago

I like the idea of having the option on both config types. An idea for the menu naming: "Scan", "Enter SSID", and then under both of those "Manual Config y/n?". The thinking is that the user first has to determine the network to connect to, so make the decision point for that very obvious ("Either I can scan for it or enter the SSID myself)". Then, once the network is specified, they can decide to configure the parameters of that network manually or not. This is mostly a "user experience" thing, but I feel that moving the word "manual" to the part that then goes into typing in the IP/gateway/etc. makes more sense, and for the top level, specifically telling the user "choose this option to enter the SSID" removes any ambiguity.

adammhaile commented 8 years ago

Complete.