search

ManifestWebDesign / angular-gridster

An implementation of gridster-like widgets for Angular JS
http://manifestwebdesign.github.io/angular-gridster/
MIT License
964 stars 394 forks source link

Cannot use bower install with v0.13.4 #292

Open chinchiheather opened 9 years ago

chinchiheather commented 9 years ago

With the module loading stuff added into v0.13.4 I can no longer do a bower install and use angular-gridster. If I try, I get an error when loading my site which says "angular.module" is not defined coming from line 21 of angular-gridster.js. Using v0.13.2 I have no issues.

apopa01 commented 9 years ago

I have same issue, too. I believe you correct in this week, best regards.

chinchiheather commented 9 years ago

Any more information on this?

danomatic commented 9 years ago

I cannot reproduce this issue. Can you give more detail?

chinchiheather commented 9 years ago

I have installed angular-gridster by running 'bower install angular-gridster' and I am using gulp to build my project. With the latest version, when I open my project in the browser I get an error in the angular-gridster js file at line 21:

"angular.module" is not defined

If I install the prev version 0.13.2, then it all works fine. It seems to have been caused by the new module loading structure.

Thanks!

danomatic commented 9 years ago

I've not used gulp and my grunt build does not have this issue. The new module loading feature was for another user, but it didn't break anything for me. Do you have a suggested fix in mind that would help your use case? ᐧ

Dan Blaisdell (503) 382-9273 (Cell) (503) 746-9116 (Office) manifestwebdesign.com

On Tue, Jul 14, 2015 at 10:23 PM, Heather Roberts notifications@github.com wrote:

I have installed angular-gridster by running 'bower install angular-gridster' and I am using gulp to build my project. With the latest version, when I open my project in the browser I get an error in the angular-gridster js file at line 21:

"angular.module" is not defined

If I install the prev version 0.13.2, then it all works fine. It seems to have been caused by the new module loading structure.

Thanks!

— Reply to this email directly or view it on GitHub https://github.com/ManifestWebDesign/angular-gridster/issues/292#issuecomment-121492160 .

chinchiheather commented 9 years ago

Hmm okay, I will have a look into it and try and find something :)

chinchiheather commented 9 years ago

So I have made a pull request that has a fix in it for the issue I was encountering. It seemed to be caused by a combination of gulp, bower & browserify, where the require() method in the common JS section of the UMD bit returned an empty object. But it still put angular on the global namespace, so I found I could run require('angular') than just call factory() passing in the global variable angular. Hope that's okay and doesn't break anything...