ManifestWebDesign / angular-gridster

An implementation of gridster-like widgets for Angular JS
http://manifestwebdesign.github.io/angular-gridster/
MIT License
964 stars 394 forks source link

maxTop in 'angular-gridster/src/angular-gridster.js' #516

Open kvsystems opened 4 years ago

kvsystems commented 4 years ago

Row 1707:

maxTop = 9999

This will block gridster element height:

this.$element.css('height', (this.sizeY * this.gridster.curRowHeight - this.gridster.margins[0]) + 'px');

This will block gridster container height:

this.maxRows - maxHeight > 0 ? Math.min(this.maxRows, maxHeight) : Math.max(this.maxRows, maxHeight);

It would be nice to move these constants into the configuration:

/** @function ResizeHandle */
minTop = 0,
maxTop = 9999,
minLeft = 0;

/** @function getBoundingBox */
var maxRow = 0;
var maxCol = 0;
var minRow = 9999;
var minCol = 9999;

We are waiting for the solution of this issue, we use your library on one and old projects. Thank you in advance.