Revisions to standalone header feature

[dananjohnson]

• [x] apply shadow on standalone header to library header as well
• [x] standardize background color on dropdown menus
• [x] press header text has clipping on descenders
• [x] standalone footer needs focus-visible style pass
• [x] vertical alignment regression on library header (see comments below)
• [x] reader footer logo margin regression (image below)
• [x] correct standalone mode instructions
• [x] Add default background color to press header (Manifold green) and update hover/focus state
• [x] Fix regressions in hero styles (see below)
• [x] Regression to notification placement
• [x] Too much header spacing on resource collection view
• [x] check standalone mode persistence
• [x] Moving from reader on standalone project to manage groups does not exit standalone mode.
• [x] Logging out of account in standalone mode triggers TypeError
• [x] Logging out while on a standalone project page takes you to HP and the standalone proj header persists

[zdavis]

Comps:

Implementation:

[tsmyre]

The Standalone mode tool tip reads incorrectly at present:

If enabled, this project will always render in standalone mode when “&mode=standalone” is appended to the URL.

The ampersand should be a question mark: ?mode=standalone.

[tsmyre]

Also, when toggled to Enabled a project does not persist the ?mode=standalone in the URL when a user clicks on a text. For example, see this project: https://edge.manifoldapp.org/projects/the-adventures-of-sherlock-holmes?mode=standalone.

If you click on any of the texts and enter the reader, the menu you see will still provide all the options available for library view: Project Home, Projects, Following. If you nav back that way, Standalone is no longer visible.

Likewise, if you return fresh to https://edge.manifoldapp.org/projects/the-adventures-of-sherlock-holmes?mode=standalone and click on any resource, when you arrive at the resource page the standalone suffix will be gone, though the standalone header will persist. If you use that to nav back to the project home, the standalone header will be there even though the URL suffix is not showing. However if you click refresh, you'll be out of standalone.

[zdavis]

reader footer logo margin regression

[tsmyre]

I'm wondering if there should be a default header bar color when a user doesn't specify one in settings. Right now the bar turns white and is only visible on hover if no color is provided.

[tsmyre]

I'm also wondering if it would be possible to have a toggle that allows a public project to be in standalone and not appear in the library. I suspect that will be a highly sought after means of conveying projects when in standalone.

[dananjohnson]

I'm wondering if there should be a default header bar color when a user doesn't specify one in settings. Right now the bar turns white and is only visible on hover if no color is provided.

Yeah there definitely needs to be a default color here. Without one specified, the BG is actually just transparent.

[zdavis]

Could you implement this, Dana? I say we go with the manifold green as default.

[dananjohnson]

Can do! Although that green is also the hover color. I'm wondering if we should make green the default, but update the hover/focus state to just lighten or darken whatever the BG color is.

[zdavis]

I like that idea

[dananjohnson]

• title should be present in library mode
• image should be centered

Comps:

Current:

[zdavis]

[dananjohnson]

This is the checkStandaloneMode method in client/src/frontend/containers/ProjectWrapper/index.js.

[dananjohnson]

@zdavis I'm having trouble reproducing the issue with notification placement. The position looks right when I test it. Are you seeing it in all cases or just in certain circumstances?

[zdavis]