ManifoldScholar / manifold

Transforming scholarly publications into living digital works.
http://manifoldapp.org
GNU General Public License v3.0
236 stars 30 forks source link

Bad breaks in the Reader #2913

Closed tsmyre closed 3 years ago

tsmyre commented 3 years ago

With recent updates I've been noticing bad line breaks and spacing more and more. I suspect that is on account of my regularly shifting the parameters of the Reader (shrinking the font, expanding and collapsing the margins).

At first I thought this had to do with our texts commonly being justified:

justify

In response I added a stylesheet that left-aligned the affected content. But this turned up something more. You can see in these two shots that the text is now left-aligned but lines are breaking curiously. Each of these show one single paragraph:

Example 1

bad

Example 2

break

This Text lives here. As you changing the settings in the Reader (text size and margins) you'll start to see how the breaks occur within paragraphs render.

We started talking through this on Slack, where Zach reported that disabling the following global declaration in our CSS resets seems to mitigate some problems:

*, *::before, *::after {
  box-sizing: border-box;
}
tsmyre commented 3 years ago

Another example from a recently loaded text.

bio

This is the coding for this paragraph:

<p class="aubiof"><span class="aubion">Ma Vang</span> is an assistant professor and founding chair of Critical Race and Ethnic Studies at the University of California, Merced. Her forthcoming book, <i>History on the Run: Secrecy, Fugitivity, and Hmong Refugee Epistemologies</i>, examines how secrecy structures both official knowledge and refugee epistemologies about militarism and forced migration. She is the coeditor of <i>Claiming Place: On the Agency of Hmong Women</i> (University of Minnesota Press, 2016), and her writings have been published in <i>positions: asia critique</i> and <i>MELUS</i>. With a UC Multicampus Research grant, she is a founding member of the Critical Refugee Studies Collective, which aims to ethically reconceptualize refugee lifeworlds to make apparent processes of colonization, war, and displacement. She serves as coeditor of its website, which hosts the refugee archive and story map platforms for refugees to share stories. She is also actively engaged with student and community organizations.</p>
tsmyre commented 3 years ago

This is also being reported on the UMass instance.

Here we see one single paragraph that breaks at the resource annotation.

umass
zdavis commented 3 years ago

Hey @dananjohnson, could you pause on the OER work at some point in the next day or two to look at this issue and let me know what you think? I'd like to address this for v6 if it's not too much work.

zdavis commented 3 years ago

Hey @tsmyre — Dana and I are no longer able to reproduce this problem. When you have a chance, could you check and see if you're able to reproduce these issues?

tsmyre commented 3 years ago

Likewise, I'm not longer seeing this either. Is this something that could have been happening because of something going on in Chrome?

zdavis commented 3 years ago

Could be a browser issues that was fixed, or a manifold issue that we fixed without knowing it. I'm closing this and we can reopen if it pops up again.