Manim-Notebook / manim-notebook

Simple commands to replicate the manim dev workflow in VSCode
MIT License
5 stars 0 forks source link

Support shortcut for starting `manimgl` interactively based on current line #2

Closed Splines closed 1 week ago

Splines commented 2 weeks ago

Such a command (with an assignable shortcut) could do the following

Steps

Additional

VladimirFokow commented 2 weeks ago

implemented here

bhoov commented 1 week ago

Argh, I would really like to have this functionality as part of the extension before I publish this extension's awesome recent developments (thanks you both!) to the marketplace. However, after doing some research the CC-BY-NC-SA license is not compatible with the MIT license I am currently using. We have two options:

  1. We can implement our own logic from scratch, without inspiration from the original implementation. Or,
  2. We can update the extension's license to CC-BY-NC-SA

I believe this is a very important feature to have as part of the extension. Let me know your thoughts

VladimirFokow commented 1 week ago

Hi! Really awesome contributions from @Splines !

I believe Grant has allowed to use the workflow itself without the CC license.

bhoov commented 1 week ago

Oh sick. Let's get this functionality implemented then. Do you want to prep the PR against main?

VladimirFokow commented 1 week ago

Yes: #17

bhoov commented 1 week ago

This was closed by #17