Manim-Notebook / manim-notebook

Simple commands to replicate the manim dev workflow in VSCode
MIT License
5 stars 0 forks source link

[bug] log file not cleared on reload-window (MacOS) #58

Closed VladimirFokow closed 2 days ago

VladimirFokow commented 3 days ago

See 5 messages here:

https://github.com/bhoov/manim-notebook/pull/57#issuecomment-2444095357

Is the old log file ever cleared? I just reloaded the window, opened the log file, but all my old logs are still there.. (I thought the README says to reload the window - in order for the old logs to be removed?)

Splines commented 3 days ago

wanted behavior is described in this video

Splines commented 3 days ago

@VladimirFokow I've opened an issue for this in the vscode repo here. Feel free to subscribe to it should they have MacOS-specific questions.

VladimirFokow commented 3 days ago

To solve this issue for v0.1.0 NOW:

Long afterwards, if/when the technical limitations are solved by the VSCode maintainers, our workflow can be improved accordingly.

But we don't need to wait for them now - we can still make this extension usable comfortably & bug-free.

Splines commented 2 days ago

To solve this issue for v0.1.0 NOW:

Thanks, that's indeed a valid proposal. But in my opinion it would be too clunky for users. I don't want to tell them they have to follow different parts of the Readme just because they are on different operating systems.

That's why I propose a new way of doing things in #59, which is now again ready for your review.

VladimirFokow commented 2 days ago

The new way is awesome! This issue will be closed by it