Closed naveen521kk closed 3 years ago
@PhilippImhof Can we add any font to test? If yes, what to. We need to think about license also...
I will merge this tomorrow if it doesn't get any review.
I cannot check the windows part, but will definitely have a look for Mac OS. Maybe you can request another reviewer before just merging it?
I cannot check the windows part
There are some tests checking things there (checks whether there are any warnings from Pango). So, I can be sure of saying that things work.
but will definitely have a look for Mac OS
:+1:
Maybe you can request another reviewer before just merging it?
Don't know who to actually ask. Any suggestions?
Also, can you look into the other parts of code I have edited?
I don't know how automerge worked now..
Changes
Possibly @PhilippImhof may know how to do so in macOS.