search

ManimCommunity / ManimPango

Binding for Pango, to use with Manim.
https://manimpango.manim.community
MIT License
43 stars 13 forks source link

Provide similar API across Platforms #16

Closed leotrs closed 3 years ago

leotrs commented 3 years ago

Right now, the usage in manim/mobject/svg/text_mobject.py is this:

        if sys.platform.startswith("linux"):
            manimpango.unregister_font()
        else:
            manimpango.unregister_font(str(file_path))

It would be nice to pull this check into unregister_file itself.

naveen521kk commented 3 years ago

Two things: Either:

  1. https://github.com/ManimCommunity/manim/pull/939 should be waited for this to be implemented and it can be part of v0.1.8 release.
  2. Or merge that PR, and later add this and tag it v0.2.0 so that things don't break. What do you think @leotrs? What can be done?

(doing this is very simple and I will make a PR soon. Just need a plan on what to do)

leotrs commented 3 years ago

Number 2 sounds like it breaks fewer things so let's go with that.