search

ManimCommunity / ManimPango

Binding for Pango, to use with Manim.
https://manimpango.manim.community
MIT License
46 stars 13 forks source link

Cleaning Code #30

Open naveen521kk opened 3 years ago

naveen521kk commented 3 years ago

There is a significant copy-pasting of the same code, for Text and MarkupText, instead if needs to be cleaned up so it is more maintainable.

PhilippImhof commented 3 years ago

I suggest having some sort of AbstractText class containing all common parts (where it is sensible) and then have Text and MarkupText as extensions of AbstractClass.

naveen521kk commented 3 years ago

@PhilippImhof are you interested in doing this?

PhilippImhof commented 3 years ago

Yes, absolutely. I will draft a concept and discuss it with you before I start coding. But I need some time...