naveen521kk commented 3 years ago

fixes #34 This change is valid only for MarkupText because Text has a different structure and needs to be refactored later.

TODO:

Add some tests.

naveen521kk commented 3 years ago

@PhilippImhof can you review this?

PhilippImhof commented 3 years ago

I will try to do so this weekend. Sorry, been a bit busy lately.

naveen521kk commented 3 years ago

I won't be available for the next week or so, feel free to merge it if everything is good :)

codecov-io commented 3 years ago

Codecov Report

Merging #40 (62ac355) into main (f77b42d) will increase coverage by 0.55%. The diff coverage is 85.00%.

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   80.55%   81.10%   +0.55%     
==========================================
  Files           6        6              
  Lines         288      307      +19     
==========================================
+ Hits          232      249      +17     
- Misses         56       58       +2

Impacted Files	Coverage Δ
manimpango/cmanimpango.pyx	`67.45% <81.25%> (+1.22%)`	:arrow_up:
manimpango/enums.pyx	`100.00% <100.00%> (ø)`
manimpango/register_font.pyx	`95.23% <0.00%> (+1.58%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f77b42d...b25c0fa. Read the comment docs.

naveen521kk commented 3 years ago

@PhilippImhof if you are free can you review this?

ManimCommunity / ManimPango

feat: add justify, indent, alignment options #40

Codecov Report