Closed naveen521kk closed 2 years ago
Do we have to do something about the failing build?
Ah, sorry I didn't mark it as a draft. It's still a WIP.
Ah, sorry I didn't mark it as a draft. It's still a WIP.
OK, fine. You actually seemed to even have requested a review :)
You actually seemed to even have requested a review :)
I guess that's because you are a Code owner here,
@PhilippImhof This PR is ready and waiting for your review :).
@PhilippImhof Thanks for the review. It would be nice if you could test the macOS wheels also https://github.com/ManimCommunity/ManimPango/suites/4557070397/artifacts/122415312
I currently have some environment problems on my machine and thus cannot properly test the macOS wheels. But I think we can go for it, no?
But I think we can go for it, no?
Yeah, I guess at least it works on Github's machine.
I'll do a release later today. I guess it should be a major bump right because of https://github.com/ManimCommunity/ManimPango/pull/65
windows-2016
(it's nearing EOL) see #66