macOS: build a shared library in wheels

ManimCommunity / ManimPango

Binding for Pango, to use with Manim.

https://manimpango.manim.community

MIT License

41 stars 13 forks source link

macOS: build a shared library in wheels #71

Closed naveen521kk closed 2 years ago

PhilippImhof commented 2 years ago

What are we doing about the failing tests?

naveen521kk commented 2 years ago

What are we doing about the failing tests?

I know why the tests were failing https://www.msys2.org/news/#2021-12-21-potential-incompatibilities-with-newer-python-setuptools, I will fix them soon.

naveen521kk commented 2 years ago

Also, it would be better if you test whether the tests work with the in the PR: https://github.com/ManimCommunity/manim/pull/2341

PhilippImhof commented 2 years ago

I will do so, probably tomorrow (UTC+1)

naveen521kk commented 2 years ago

What are we doing about the failing tests?

Normal windows test also fails, I just thought msys2 one failed. I will see what is really happening.

PhilippImhof commented 2 years ago

Tested with code from ManimCommunity/manim#2341. Using these wheels, tests work. Using statically linked wheels from main branch, tests crash locally just like they do in CI.