search

ManimCommunity / ManimPango

Binding for Pango, to use with Manim.
https://manimpango.manim.community
MIT License
45 stars 13 forks source link

Change to MIT license #72

Closed naveen521kk closed 2 years ago

naveen521kk commented 2 years ago

All the authors and contributors have agreed to this change.

Fixes https://github.com/ManimCommunity/manim/issues/2418

naveen521kk commented 2 years ago

Pinging all contributors so they are aware of this change: @PhilippImhof, @RickyC0626, @marcin-serwin, @jsonvillanueva

naveen521kk commented 2 years ago

It looks like it's fine to license ManimPango under MIT license, as an example I saw the gtk-rs project today, its license: https://github.com/gtk-rs/gtk-rs-core/blob/166f0055bffbfc8c05b4f621d4d7704a00a21c24/COPYRIGHT

While the code here for binding will be licensed under MIT license the wheels that are distributed on PyPI is subject to GNU LGPL, the license is here. I think I should add a note about that on README and also change the license in setup.py.

naveen521kk commented 2 years ago

We should make a new release now, right? What should be its version, I guess bump minor version?

PhilippImhof commented 2 years ago

Absolutely. I'd say this should be a post release according to PEP 440:

Some projects use post-releases to address minor errors in a final release that do not affect the distributed software (for example, correcting an error in the release notes).

naveen521kk commented 2 years ago

I'll do later this evening. Thanks