ManimCommunity / manim-voiceover

Manim plugin for all things voiceover
https://voiceover.manim.community/en/stable
MIT License
154 stars 20 forks source link

Incompatibilities due to new openai-whisper version #55

Open JaMeZ-B opened 1 year ago

JaMeZ-B commented 1 year ago

Preliminaries

Description of error

I believe that it has become impossible to use transcripition with openai-whisper on macOS (and presumably Windows) in the latest version of manim-voiceover.

Let me explain: Recently the transcription module was updated to be compatible with openai-whisper>20230306. This whisper version adds a dependency on openai's triton, which unfortunately has only manylinux wheels, as you can see here. Hence, on non-Linux machines manually building triton (in version >=2.0.0) is the only option to get the transcription part of manim-voiceover to work.

To me personally this means, that I will stick to the Azure service or even use two different python environments (I wanted to use GTTS for early versions of my next video because its free).

Installation logs

Terminal output poetry error when setting up the environment: ``` Unable to find installation candidates for triton (2.0.0.post1) ```

System specifications

System Details - OS: macoS 13.3.1 - RAM: 64 GB - Python version (`python/py/python3 --version`): 3.11
LaTeX details + LaTeX distribution (e.g. TeX Live 2020): + Installed LaTeX packages:
FFMPEG Output of `ffmpeg -version`: ``` PASTE HERE ```

Additional comments

osolmaz commented 1 year ago

Are you on Mac M1 or intel? I am also on M1 with MacOS 13.3, and I did not experience any issues with triton.

Also, can you maybe try with Python 3.10 and let me know if that changes anything?

JaMeZ-B commented 1 year ago

I just tried it on an Intel mac with python 3.10.11 and the following pyproject.toml:

[tool.poetry]
name = "manim-test"
version = "0.1.0"
description = ""
authors = ["Jannes Bantje <j.bantje@wwu.de>"]
readme = "README.md"
packages = [{include = "manim_test"}]

[tool.poetry.dependencies]
python = "3.10.11"
manim = "^0.17"
manim-voiceover = { version = "^0.3.3", extras = ["all"] }

[tool.poetry.group.dev.dependencies]
ipython = "*"
ipykernel = "*"
setuptools = "*"
wheel = "*"

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

sadly the triton dependency still causes Unable to find installation candidates for triton (2.0.0)

I will try it on my M1 mac later. EDIT: The same setup on my M1 machine creates the same error message from poetry

osolmaz commented 1 year ago

I take it back, I am able to reproduce this locally. Will figure out the best way to resolve this

osolmaz commented 1 year ago

I just released v0.3.3.post which removes triton from poetry.lock. Does this fix the installation issue for now?