search

ManimCommunity / manim-voiceover

Manim plugin for all things voiceover
https://voiceover.manim.community/en/stable
MIT License
171 stars 23 forks source link

fix windows path to string bug #70

Closed mkali-weizmann closed 1 year ago

mkali-weizmann commented 1 year ago

In the modified line the Path was changed to a string. In Windows, without this added "str", the sox function throws an error for having a Path argument instead of an str argument (the exception is thrown in sox/core, line 51).

osolmaz commented 1 year ago

Thanks for the correction!

mkali-weizmann commented 1 year ago

Thanks for the correction!

Sure :-)

Thank you so much for the library, I just spent a few days making a very cool video with the voiceover of Azure, and it was extremely convenient! A year ago I did a similar video without your library, and I can sincerely say it saves A LOT of time.

I will use this opportunity to say that I think the most important thing now is to make caching available also for the voiceover videos, as exporting it without caching took quite a lot of time.