fix: importing manim should not trigger pygments.styles.get_all_styles - Githubissues

ManimCommunity / manim

A community-maintained Python framework for creating mathematical animations.

https://www.manim.community

MIT License

21.42k stars 1.57k forks source link

fix: importing manim should not trigger pygments.styles.get_all_styles #3797

Closed goldenphoenix713 closed 3 months ago

goldenphoenix713 commented 3 months ago

Overview: What does this pull request change?

Removed the Code.styles_list attribute.

Added new class method Code.get_styles_list().

Rewrote the documentation to say that a list of all styles can be generated by calling a new class method.

The example in the docstring of Code was rewritten to use an explicit code style name.

Motivation and Explanation: Why and how do your changes improve the library?

See https://github.com/ManimCommunity/manim/issues/3713 for issue.

Links to added or changed documentation pages

https://manimce--3797.org.readthedocs.build/en/3797/

Further Information and Comments

First contribution!

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

JasonGrace2282 commented 3 months ago

Hey, I'll take a look at this within the next few days, as I'm a bit busy right now. Just wanted to let you know that we see this PR and intend to review it :)