ManimCommunity / manim

A community-maintained Python framework for creating mathematical animations.
https://www.manim.community
MIT License
26.7k stars 1.83k forks source link

Fix incorrect assignment in Mobject.put_start_and_end_on #4008

Open dark opened 2 weeks ago

dark commented 2 weeks ago

Overview: What does this pull request change?

PR #3718 changed the behavior of Mobject.put_start_and_end_on when start == end, however the assigment to self.points was incorrect. The existing code assigned the Point3D directly to self.points, that then becomes an array with shape (3,), while instead it should really have shape (1, 3).

This commit fixes the incorrect code and associated test.

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist