search

Manish-Kothary / CBDbene

1 stars 0 forks source link

Mobile view | Add to cart #56

Open Manish-Kothary opened 5 years ago

Manish-Kothary commented 5 years ago

Mobile view | Add to cart : Not working. image.png

Manish-Kothary commented 5 years ago

Not able to add to cart as it is showing one empty entry, but in case of mobile, how will be able to know that, unless and untilI I have to scroll the whole page.

Anas-MI commented 5 years ago

explain it.

Priya0419 commented 5 years ago

In mobile view:

  1. When i click the add to cart button; it must change the text to "added".
  2. If any field in product page is remained empty and still the user is clicking the add to cart button, it must scroll the page to that empty field or show some validation message.
Manish-Kothary commented 5 years ago

Priya Please cc Anas on this

On Fri, Sep 20, 2019 at 5:20 PM Priya0419 notifications@github.com wrote:

In mobile view:

  1. When i click the add to cart button; it must change the text to "added".
  2. If any field in product page is remained empty and still the user is clicking the add to cart button, it must scroll the page to that empty field or show some validation message.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Manish-Kothary/CBDbene/issues/56?email_source=notifications&email_token=ANFFML4CZXNYZTKZLRV6RUDQKS2IFA5CNFSM4IW53JD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7GOGDY#issuecomment-533521167, or mute the thread https://github.com/notifications/unsubscribe-auth/ANFFML36DB743P2GXPD2QUDQKS2IFANCNFSM4IW53JDQ .

-- Thanks & Regards, Manish Kothary M: +91.995.896.6881(Whatsapp) | +1.646.367.3725(USA) mkothary@gmail.com | skypeid: mkotharyskype

Priya0419 commented 5 years ago

I have already assigned this to him. he'll get the notification. image

Manish-Kothary commented 5 years ago

https://www.growcode.com/blog/mobile-shopping-cart-design/ - just review this for best practices

Anas-MI commented 5 years ago

fixed

Priya0419 commented 5 years ago

This issue is still pending.

  1. Change the text of add to cart button to added.
  2. If we are getting the validation issues in the mobile screen(field is empty, automatically scroll up the page to that particular section.
Anas-MI commented 5 years ago

1st point is done

Priya0419 commented 5 years ago

Please fix point 2 .

Also, for this page(mobile & desktop) - can you set a default value either -mint or natural. It would help me for the script to run properly. and it will cover the point 2 issue with it. image

Anas-MI commented 4 years ago

We cant keep one as default. Its the same url for both - Mint & Natural. Doing this would confuse the user.

So we cant make such changes just to make your script work

Priya0419 commented 4 years ago

So, do fix the thing for mobile screens. It must scroll up the page to the validation error when the "add to cart" button is clicked without entering all the specifications.