Closed sushant-hiray closed 10 years ago
@Manishearth I'm more or less done with the PR. Could you review this once? The sidebar thingy doesn't look real good right now, we can work on the UI once this is merged.
Could you keep the current default color? Also, I think adding some transparency to the picked color will help. (No need for a slider)
For the sidebar, I suggest coloring the entire entry, with a slightly higher alpha value.
It's going to get used this sem (already put out some freshie timetables), so I think we should perfect the UI before merging :)
Default, sure. Transperancy, well the main in keeping picker in the sidebar was they can shift over the picker and see which color suits them. So they can perhaps go for a lighter shade.
I'll update the entire color to sidebar.
The problem is that lighter shades at full opacity also look bad as backgrounds for stuff like this.
(Try picking a good color here, its hard)
-Manish Goregaokar
Makes sense. I added a slider to the picker on top. If the choose its fine, or else I make it transparent to a preset value. for the picker on the sidebar, I just keep the preset value.
I made some changes to the sidebar. This is how it looks now. We can perhaps remove the background color, rest looks fine to me.
Merged, with some of my own changes. For some reason Github isn't recognizing that this merged. (in the future, work on a branch on this repo, so we can work together)
Thanks!
Kewl. Adding color to picker button looks much better.
TODO