search

Manishearth / elsa

Append-only collections for Rust where borrows to entries can outlive insertions
Apache License 2.0
228 stars 33 forks source link

feat: implement serde for all the containers #60

Open aminya opened 1 year ago

Manishearth commented 1 year ago

I'm going to block this on figuring out the exact solution for https://github.com/Manishearth/elsa/issues/48 since that may change a bunch of the relevant internals here and I really don't want to complicate that situation more.

aminya commented 1 year ago

I can revert those affected by #48 until this is fixed https://github.com/Manishearth/elsa/issues/48#issuecomment-1674048753

Manishearth commented 1 year ago

That's going to be most of the important ones, and plus the changes I do there may also affect other types like the BTreeMaps. I don't think it's worth landing this PR with those things removed.

aminya commented 1 year ago

I actually prefer if you merge #62 before this PR as it allows me to test serialization/deserialization back-to-back via assert_eq

aminya commented 1 year ago

Waiting for #72 so that I can add the tests for all implementations.