Manishearth / humpty_dumpty

Implicit Drop/move protection for Rust (linear types)
12 stars 1 forks source link

Remove "debug" output #14

Closed Munksgaard closed 9 years ago

Munksgaard commented 9 years ago

There's a lot of unnecessary debug output when running humpty_dumpty. For example, compiling tests/if-return.rs yields:

tests/if-return.rs:13:14: 13:18 note: Adding drop protected type to map. Id: 11
tests/if-return.rs:13     fn close(self) { }
                                   ^~~~
tests/if-return.rs:18:9: 18:10 note: Adding drop protected type to map. Id: 21
tests/if-return.rs:18     let f = Foo;
                              ^
tests/if-return.rs:21:9: 21:10 note: Consuming protected var
tests/if-return.rs:21         f.close();
                              ^
tests/if-return.rs:30:9: 30:10 note: Adding drop protected type to map. Id: 40
tests/if-return.rs:30     let f = Foo;
                              ^
tests/if-return.rs:33:9: 33:10 note: Consuming protected var
tests/if-return.rs:33         f.close();
                              ^
tests/if-return.rs:39:5: 39:6 note: Consuming protected var
tests/if-return.rs:39     f.close();
                          ^
tests/if-return.rs:44:9: 44:10 note: Adding drop protected type to map. Id: 61
tests/if-return.rs:44     let f = Foo;
                              ^
tests/if-return.rs:47:9: 47:10 note: Consuming protected var
tests/if-return.rs:47         f.close();
                              ^
tests/if-return.rs:50:9: 50:10 note: Consuming protected var
tests/if-return.rs:50         f.close();
                              ^
tests/if-return.rs:57:9: 57:10 note: Adding drop protected type to map. Id: 83
tests/if-return.rs:57     let f = Foo;
                              ^
tests/if-return.rs:62:9: 62:10 note: Consuming protected var
tests/if-return.rs:62         f.close();
                              ^
tests/if-return.rs:66:5: 66:6 note: Consuming protected var
tests/if-return.rs:66     f.close();
                          ^
tests/if-return.rs:71:9: 71:10 note: Adding drop protected type to map. Id: 104
tests/if-return.rs:71     let f = Foo;
                              ^
tests/if-return.rs:78:5: 78:6 note: Consuming protected var
tests/if-return.rs:78     f.close();
                          ^
tests/if-return.rs:85:9: 85:12 note: Adding drop protected type to map. Id: 122
tests/if-return.rs:85     let foo = Foo;
                              ^~~
tests/if-return.rs:88:9: 88:12 note: Consuming protected var
tests/if-return.rs:88         foo.close();
                              ^~~
tests/if-return.rs:92:5: 92:8 note: Consuming protected var
tests/if-return.rs:92     foo.close();
                          ^~~
tests/if-return.rs:98:9: 98:12 note: Adding drop protected type to map. Id: 143
tests/if-return.rs:98     let foo = Foo;
                              ^~~
tests/if-return.rs:101:9: 101:12 note: Consuming protected var
tests/if-return.rs:101         foo.close();

which is clearly undesired. Many of these are trivial and should be removed, others should be hidden behind RUST_LOG.

Munksgaard commented 9 years ago

This was actually fixed with 0b98c9fcfe. For now, the debug output has been removed. At some point it might be interesting to add some RUST_LOG capabilities to humpty, but that's not necessary for now.