BrowserFolders can hang during shutdown or when leaving maker

[GeBo1]

Not sure when this started, but it's not just in the latest version.

Steps to recreate in KK main game:

• Launch main game to main screen
• Select female maker
• open card browser
• select alternate folder
• load a card
• click button to exit maker
• wait forever because nothing will ever happen again

This is caused by FileSystemWatcher, so easy/temporary fix is make InitFileSystemWatcher just return without doing anything, auto-updating will be disabled, but everything else will work fine.

FileSystemWatcher is IDisposable so any classes storing one as a member needs to also be IDisposable and correctly implement the disposal pattern, and so on up the object tree, but FolderTreeView is kept as a static on most classes, which complicates things.

Probably best to disable the auto-refresh until it's worked out.

[ManlyMarco]

Better to dispose in the game exit event.

[GeBo1]

That doesn't fix maker exit hanging (and I tried disposing in maker exit event and couldn't make it work). I haven't really tested with the in-game maker or other scenes in game where you select cards yet, since disabling it worked.

[ManlyMarco]

Already solved.