search

MannLabs / alphabase

Infrastructure of AlphaX ecosystem
https://alphabase.readthedocs.io
Apache License 2.0
31 stars 9 forks source link

SpecLlibFlat to specLibBase conversion #138

Closed mo-sameh closed 8 months ago

review-notebook-app[bot] commented 8 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

GeorgWa commented 8 months ago
  1. when inferring charged frag types, include all charges up to the maximum observed charge.
  2. Move all test cases into a single notebook at spectral_library/flat_library.ipynb
  3. run nbdev_clean
  4. Update remove unused to use available_fragment_dfs() as source of dense fragments df

Then we are ready to merge 🚀