rename diann spec_idx to diann_spec_idx

MannLabs / alphabase

Infrastructure of AlphaX ecosystem

https://alphabase.readthedocs.io

Apache License 2.0

31 stars 9 forks source link

rename diann spec_idx to diann_spec_idx #142

Closed jalew188 closed 8 months ago

jalew188 commented 8 months ago

After pandas upgrade, some df.values will be readonly in Linux. This PR is designed to fix some read-only issues.

review-notebook-app[bot] commented 8 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jalew188 commented 8 months ago

Fix #143 ?

GeorgWa commented 8 months ago

Hi Feng, looks good 👍 what is the origin of that bug? Is it Pandas?

Just to make sure that I understand it if it happens to me.

jalew188 commented 8 months ago

Hi Feng, looks good 👍 what is the origin of that bug? Is it Pandas?

Just to make sure that I understand it if it happens to me.

Hi @GeorgWa, from the auto tests, I guess it is due to pandas version and only on Linux. I think all iloc.values will be a readonly property instead of a ref of numpy array. I am not entirely sure anyway.