MannLabs / alphabase

Infrastructure of AlphaX ecosystem
https://alphabase.readthedocs.io
Apache License 2.0
28 stars 8 forks source link

implement SpecLibFlat.remove_unused_fragments() #146

Closed GeorgWa closed 4 months ago

GeorgWa commented 6 months ago

Currently, remove_unused_fragments is only implemented for dense libraries. An implementation for flat libraries would be very usefull and should be easy to implement.

jalew188 commented 6 months ago

I think we already have args frag_start_col and frag_stop_col for different cases, see https://github.com/MannLabs/alphabase/blob/main/alphabase/peptide/fragment.py#L867

jalew188 commented 6 months ago

I designed this for spectrum_df's peak_start_idx and peak_stop_idx, flat_lib case should be similar

GeorgWa commented 6 months ago

I agree, it's most likely a very simple function and we can use https://github.com/MannLabs/alphabase/blob/main/alphabase/peptide/fragment.py#L867

jalew188 commented 4 months ago

Is this issue still required? @GeorgWa

GeorgWa commented 4 months ago

It was implemented in #149 👍