MannLabs / alphadia

modular & open DIA search
https://alphadia.readthedocs.io
Apache License 2.0
41 stars 3 forks source link

Calibration results are shown as floating point numbers exactly matching the target #117

Closed vbrennsteiner closed 2 months ago

vbrennsteiner commented 5 months ago

Describe the bug Not so much a bug as a potential source of confusion: When running a search with AlphaDIA, the log informs the user about whether calibration targets have been reached in the current epoch. The log states the following information:

In the current implementation, actual values are exactly equal to targets (see attached screenshot) which suggests that 'actual' is not the final calibrated value but instead the target value. It would be informative to see the actual calibration results at this point, hence the request.

To Reproduce Steps to reproduce the behavior:

  1. Go to GUI
  2. Click on 'Run Workflow' (after selecting rawfiles + spectral library or fasta)
  3. Click on 'Console Output'
  4. Scroll down to green checkmarks / red 'x' icons indicating whether calibration targets have been reached
  5. See error: actual values are exactly equal to targets

Expected behavior Reached calibration values are not expected to exactly match targets to such precision in all cases

Logs

Screenshots If applicable, add screenshots to help explain your problem. image

Version (please complete the following information):

Additional context