MannLabs / alphapeptstats

Python Package for the downstream analysis of mass-spectrometry-based proteomics data
https://alphapeptstats.readthedocs.io/en/latest/
Apache License 2.0
61 stars 15 forks source link

Idhandling I #378

Closed JuliaS92 closed 4 days ago

JuliaS92 commented 1 week ago

Major changes:

JuliaS92 commented 1 week ago

The failing tests are fixed in the next PR https://github.com/MannLabs/alphapeptstats/pull/379

JuliaS92 commented 1 week ago

All resolved conversations were either addressed in the two child branches, or added as TODO in this commit: https://github.com/MannLabs/alphapeptstats/pull/383/commits/adb223e6892fb7655d3439791b5f29909734a9cc

JuliaS92 commented 5 days ago

I realize now this was not the best workflow to squash the reviews. You can get an overview of the changes made to address all your comments on the three squashed PRs here: https://github.com/MannLabs/alphapeptstats/compare/f96dc60..af2f702

Quick fixes were included here and here