search

MannLabs / alphatims

An open-source Python package for efficient accession and visualization of Bruker TimsTOF raw data from the Mann Labs at the Max Planck Institute of Biochemistry.
https://doi.org/10.1016/j.mcpro.2021.100149
Apache License 2.0
81 stars 25 forks source link

python 3.10 #218

Closed liquidcarbon closed 1 year ago

liquidcarbon commented 2 years ago

Hello! I cloned and edited alphatims/__init__.py to allow for python 3.10 and built a wheel with it. It appears to install and work fine. Would you mind officially allowing python 3.10?

Some key dependencies:

  • Installing llvmlite (0.39.0)
  • Installing numpy (1.22.4)
  • Installing numba (0.56.0)
  • Installing alphatims (1.0.0 alphatims/alphatims-1.0.0-py3-none-any.whl)
liquidcarbon commented 2 years ago

have you had a chance to look into allowing python 3.10?

sander-willems-bruker commented 1 year ago

Sorry, seems like I stopped receiving mails from the AlphaTims repo. I updated the versioning to: __python_version__ = ">=3.8,<4", on the dev branch, and will probably make an official new release next week. Thanks for checking this!

jspaezp commented 1 year ago

Hello there! I wanted to ask if this is officially supported? (if so, I think the readme could be updated to specify the versions allowed!)

Sections like alphaTims can be installed in an existing Python 3.8 environment might be misleading.

Let me know if you would like PR to fix that! Kindest wishes, Sebastian

sander-willems-bruker commented 1 year ago

Yes, that is official by now! Mainting docs is always difficult though, feel free to make a PR into the dev branch and replace any of the docs which are faulty (perhaps also the tutorial nbs)! Thanks for pointing it out.