search

MannLabs / timsrust

Apache License 2.0
20 stars 9 forks source link

feat: updated to miniTDF conventions. Adapted test names accordingly #10

Closed sebastian-wehner-bruker closed 8 months ago

sebastian-wehner-bruker commented 8 months ago

For the release of ProteoScape 2024 the naming conventions for miniTDF were changed to more accurately represent what the files contain. This updated naming convention is included in this PR for miniTDF spectrum reading. The test-file-names were also adapted accordingly.

sander-willems-bruker commented 8 months ago

We can consider doing some if these checks in file_format. For completeness, we should perhaps also enforce the existence of regular "analysis.tdf" and "_bin" files rather than just looking at the extension

sebastian-wehner-bruker commented 8 months ago

I made a change in the function checking for file formats: As miniTDF does not have a defined extension for the parent directory (other than tdf, which has the ".d" extension). The assumption should be that the provided directory should either be a tdf or minitdf. No other file formats are supported for reading anyways. This is also super helpful for the ProteoScape workflow usecase, where no requirements for the directory name for miniTDF files are being made.