MannLabs / timsrust

Apache License 2.0
20 stars 9 forks source link

Publicly expose lower level functions (SqlReader, TDFReader, DIA table readers) to allow for flexible parsing options #16

Closed arnscott closed 3 months ago

arnscott commented 3 months ago

Hello! Thanks for putting in the work on this crate! Very exciting to have some native support for timsTOF files in rust.

I was wondering if you had any plans on exposing some of the lower level functions in the crate for public use so they can be used through cargo. Structs such as the TDFReader, SqlReader, and the DIA table readers, would make it much easier to try and implement parsing for tools to analyze DIA data. I saw there was an open pull request regarding DIA data, but there doesn't seem to have been much movement on it recently.

Hope to hear back from you!

sander-willems-bruker commented 3 months ago

Hi @arnscott , thanks for the interest in TimsRust.

Indeed there has bene little activity due to more pressing priorities. By now I should be able to work on Timsrust more actively.

We purposefully tried to keep the API as small as possible to also keep it as simple as possible:

All that said, feel free to recycle and copy-paste what you think is useful, or alternatively keep a local fork which exposes what you need as a current work around.