Closed fleboulch closed 3 months ago
Thanks @fleboulch :+1:
I don't know why the CI is failing. My change should not break it
@fleboulch I tried opening another PR, and its build passes though: https://github.com/ManoManoTech/homer/pull/14
I just restarted the failed job, in case this was transient.
Still fails :(
There are other occurrences of git.manomano.tech
in the project:
$ rg 'git.manomano'
__mocks__/node-fetch.ts
11: if (url.includes('git.manomano.tech') || url.includes('slack')) {
src/core/typings/GitlabUser.ts
9: /** URL of user profile (ex: https://git.manomano.tech/josselin.buils) */
Please change them, I bet changing the first one will fix the build.
Thanks @greg0ire!
I think this build will be green!
That's why when I opened this PR I did a change without changing any hardcoded value...
Thanks @fleboulch !
@pfongkye I did the update