search

ManoManoTech / homer

Homer is a Slack bot intended to help you to easily share and follow Gitlab merge requests.
MIT License
29 stars 8 forks source link

Add an environment variable for gitlab url #10

Closed fleboulch closed 3 months ago

fleboulch commented 3 months ago

@pfongkye I did the update

pfongkye commented 3 months ago

Thanks @fleboulch :+1:

fleboulch commented 3 months ago

I don't know why the CI is failing. My change should not break it

greg0ire commented 3 months ago

@fleboulch I tried opening another PR, and its build passes though: https://github.com/ManoManoTech/homer/pull/14

greg0ire commented 3 months ago

I just restarted the failed job, in case this was transient.

greg0ire commented 3 months ago

Still fails :(

There are other occurrences of git.manomano.tech in the project:

$ rg 'git.manomano'
__mocks__/node-fetch.ts
11:  if (url.includes('git.manomano.tech') || url.includes('slack')) {

src/core/typings/GitlabUser.ts
9:  /** URL of user profile (ex: https://git.manomano.tech/josselin.buils) */

Please change them, I bet changing the first one will fix the build.

fleboulch commented 3 months ago

Thanks @greg0ire!
I think this build will be green!
That's why when I opened this PR I did a change without changing any hardcoded value...

greg0ire commented 3 months ago

Thanks @fleboulch !