search

ManoManoTech / homer

Homer is a Slack bot intended to help you to easily share and follow Gitlab merge requests.
MIT License
29 stars 8 forks source link

fix: remove the constraint on branch name #15

Closed fleboulch closed 2 months ago

fleboulch commented 3 months ago

This constraint breaks the commits interaction on git branches with a /

Steps to reproduce

  1. create a branch with a / (example: feat/my-branch)
  2. add some cool stuff and commit them
  3. push and open an MR
  4. in slack: /homer review !<ID>
  5. add a new commit
  6. you should not receive any message in the thread (whereas you should receive one)
greg0ire commented 3 months ago

Is it possible to add a test (or change existing tests so that they fail without your change?)

fleboulch commented 2 months ago

I added a new test

greg0ire commented 2 months ago

Don't mind me, just trying to trigger a pipeline with the brand new coverage action contributed in #25

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@876569b). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15 +/- ## ======================================= Coverage ? 76.78% ======================================= Files ? 64 Lines ? 1189 Branches ? 209 ======================================= Hits ? 913 Misses ? 272 Partials ? 4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fleboulch commented 2 months ago

@pfongkye did you have some time to check this MR?

pfongkye commented 2 months ago

@pfongkye did you have some time to check this MR?

Hello, Yes I left two comments. If you can take a look. Apart from this, LGTM.

fleboulch commented 2 months ago

I replied to both of them. If you agree with them I can resolve them?

pfongkye commented 2 months ago

I replied to both of them. If you agree with them I can resolve them?

Sorry @fleboulch but I'm not seeing your replies for this and this :pray:

fleboulch commented 2 months ago

They were in pending state... :boom:

greg0ire commented 2 months ago

Thanks @fleboulch !