search

ManoManoTech / homer

Homer is a Slack bot intended to help you to easily share and follow Gitlab merge requests.
MIT License
29 stars 8 forks source link

feat: make slack support channel configurable #20

Closed fleboulch closed 2 weeks ago

fleboulch commented 2 months ago

Yes you did it but when I did a force push, it has been removed

greg0ire commented 2 months ago

No: I already dismissed it on my own :)

fleboulch commented 2 months ago

I tried my best with the 2nd commit but the assertion in the waitFor is always failing. Feel free to update

greg0ire commented 2 months ago

@pfongkye, maybe?

pfongkye commented 2 months ago

@pfongkye, maybe?

Hello, I will take a look.

fleboulch commented 2 months ago

@pfongkye did you have some time to check this MR?
There are some conflicts as some other MRs have been merged

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.66%. Comparing base (28bbe41) to head (11e7418). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #20 +/- ## ========================================== + Coverage 75.63% 75.66% +0.02% ========================================== Files 93 93 Lines 1884 1886 +2 Branches 366 366 ========================================== + Hits 1425 1427 +2 Misses 429 429 Partials 30 30 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fleboulch commented 4 weeks ago

@pfongkye the MR is ready for review :rocket:

fleboulch commented 4 weeks ago

@greg0ire I applied the changes you suggested

greg0ire commented 2 weeks ago

Thanks @fleboulch !