ManoManoTech / homer

Homer is a Slack bot intended to help you to easily share and follow Gitlab merge requests.
MIT License
29 stars 10 forks source link

feat(config): use json for project configs #38

Closed pfongkye closed 1 month ago

pfongkye commented 2 months ago
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.50%. Comparing base (ffc8641) to head (ce62132). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #38 +/- ## ========================================== + Coverage 75.66% 76.50% +0.84% ========================================== Files 93 94 +1 Lines 1886 1911 +25 Branches 362 367 +5 ========================================== + Hits 1427 1462 +35 + Misses 450 440 -10 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fabienfleureau commented 1 month ago

Hello, with this evolution would it be possible to have the json injected after the build of the project? For example, homer is built and packaged in a docker image, I can mount a volume with the config file at the right place to have it loaded at startup.

pfongkye commented 1 month ago

Hello, with this evolution would it be possible to have the json injected after the build of the project? For example, homer is built and packaged in a docker image, I can mount a volume with the config file at the right place to have it loaded at startup.

Hello @fabienfleureau, For now we are building a new image with the config json copied to the correct destination but I think it is a good idea also to be able to mount a volume so that we only need to update the config file when necessary. I haven't tried it but could be a good evolution also. Let us know if you want to try this approach. Thanks.