ManoManoTech / homer

Homer is a Slack bot intended to help you to easily share and follow Gitlab merge requests.
MIT License
29 stars 10 forks source link

Squash policy (github config) #41

Closed fleboulch closed 1 week ago

fleboulch commented 1 month ago

Current behaviour

Once a PR is merged all the commits are in the main branch. If I have 15 commits they will be all in main

Expected behaviour

1 commit per PR on the main branch

cicoub13 commented 1 week ago

Done, thanks ✅

greg0ire commented 1 week ago

@cicoub13 We can make squash merge the default but I wouldn't make that the only option. When I make 3 commits, all of them are atomic, with good commit messages and I still want to be able to revert only one of them easily. Sorry for not speaking up sooner.

cicoub13 commented 1 week ago

OK with you but I would like the squash option the default one 🤔

cicoub13 commented 1 week ago

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/about-merge-methods-on-github

You can enforce one type of merge method, such as commit squashing or rebasing, by only enabling the desired method for your repository.

greg0ire commented 3 days ago

@cicoub13 I wouldn't enforce anything. It's up to us maintainers to tell apart PRs with commits that look like this:

from PRs that look like this: