ManoManoTech / homer

Homer is a Slack bot intended to help you to easily share and follow Gitlab merge requests.
MIT License
29 stars 10 forks source link

fix(deleted-project): Handle deleted Gitlab projects gracefully in project list and changelog #47

Closed M0nkeySan closed 2 weeks ago

M0nkeySan commented 2 weeks ago

What

Previously, when trying to fetch projects that existed in our database but were deleted from Gitlab, the project list and changelog modal commands would fail entirely. This was because Promise.all would reject if any single project fetch failed.

Fix

Changes:

Conclusion

This makes the system more resilient by allowing operations to continue even when some referenced projects no longer exist in Gitlab.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.26%. Comparing base (7f322f6) to head (36ec795). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/changelog/buildChangelogModalView.ts 12.50% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #47 +/- ## ========================================== - Coverage 78.38% 78.26% -0.13% ========================================== Files 94 94 Lines 1897 1909 +12 Branches 342 345 +3 ========================================== + Hits 1487 1494 +7 + Misses 401 387 -14 - Partials 9 28 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.