issues
search
Manoj-Kumar-Selvaraj
/
Python-react-Full-Stack-Website
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Declare the varaibles by the way to identify what is the purpose of it
#11
maheshritgithub
opened
1 month ago
0
It’s good practice to add a message or status field, like "message": "Barcodes retrieved successfully"
#10
maheshritgithub
opened
1 month ago
0
Wrap the database query in a try-except block to handle any unexpected database issues gracefully.
#9
maheshritgithub
opened
1 month ago
1
Please keep in tn seprate file as helper method to avoid code duplication
#8
maheshritgithub
opened
1 month ago
0
It is better to save in utc format. So it will be easier to show the local time while retreveing from the database.
#7
maheshritgithub
opened
1 month ago
1
This check is good, but the logic could be improved by explicitly logging why a duplication might happen
#6
maheshritgithub
opened
1 month ago
1
You calculate the checksum for each barcode separately in a loop. Consider extracting the checksum calculation logic to a helper method, which could improve readability and allow you to reuse it if needed.
#5
maheshritgithub
opened
1 month ago
0
please use djangos logging statements like logger.debug(f"Barcode without checksum: {barcode_without_checksum} (Length: {len(barcode_without_checksum)})")
#4
maheshritgithub
opened
1 month ago
0
The user variable here is outside of any method, which would result in an AttributeError since request is undefined at this scope. The user variable should be accessed within each request handler method (like get or post) to avoid such errors.
#3
maheshritgithub
opened
1 month ago
0
If new_barcode returns an empty list (due to an error with length or checksum), you should handle this case to notify the client of the error
#2
maheshritgithub
opened
1 month ago
0
Please remove the unnecessary files
#1
maheshritgithub
opened
1 month ago
0