ManojNimbalkar / bitcoin-wallet

Automatically exported from code.google.com/p/bitcoin-wallet
0 stars 0 forks source link

Round local currency #115

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. None: Look at main screen

What is the expected output? What do you see instead?
"worth about DKK 66.86954499" -> "worth about DKK 66.87"

What version of Bitcoin Wallet are you using: 2.20 
On what Android version and what phone? 4.0.4 on Google Nexus

Please provide any additional information below.
Just a small request for enhancement: I would like to specify how many decimal 
of local currency is shown. This could be when selecting my valuta or in 
Preferences (advanced) as this will be a one time change for most people.

Original issue reported on code.google.com by klaus.vi...@gmail.com on 5 Aug 2012 at 8:13

GoogleCodeExporter commented 9 years ago
Why would you only round local currency, and not Bitcoin values?

Also, local currency is shown at other places as well (e.g. calculator). Would 
you round it there, too?

Original comment by andreas....@gmail.com on 5 Aug 2012 at 8:19

GoogleCodeExporter commented 9 years ago
I am quite new to bitcoin so I cant judge if is relevant to the bitcoin value. 
Looking at the current value of a bitcoin I guess a rounding of 3 decimals 
would be suitable. So the same rounding is not relevant to all currencies. 
Judging from the current list in the calculator, my guess is that the people 
using SLL dont care about the decimals at all. 

So if rounding is possible all values, it should be possible to specify one for 
each valuta - and then the size of this request grows. Then a better solution 
might then be if it was possible to specify the rounding as part of the 
translating.

Original comment by klaus.vi...@gmail.com on 5 Aug 2012 at 8:45

GoogleCodeExporter commented 9 years ago
Currencies and languages are vastly different - let's not mix this together.

Rather than rounding, I'd first like to do a better job of highlighting the 
significant digits. Which is currently not correct for some currencies. Does 
anyone know of a summary of currencies and what's their smallest coin fraction? 
For EUR, I'd expect something like "0.01" (an eurocent).

As a second step, I would probably allow the user to suppress any 
non-significant digits (by rounding) via a preference option.

Original comment by andreas....@gmail.com on 10 Aug 2012 at 2:03

GoogleCodeExporter commented 9 years ago
As of version 2.33, local currencies are now rounded to 4 decimal places.

Original comment by andreas....@gmail.com on 7 Nov 2012 at 9:47